Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Register Nuclide File Tree: Rename/Delete commands at workspace level #1433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrkev
Copy link
Contributor

@mrkev mrkev commented Jan 8, 2018

Hello! I found issue #822 and thought it'd be easy enough to just fix it. This is my first PR to the project, so apologies in advance if I missed something. All feedback is appreciated!

Copy link
Contributor

@velocityboy velocityboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other menu, can you change the text to "Delete Active File"?

@mrkev
Copy link
Contributor Author

mrkev commented Jan 13, 2018

Ah, certainly

@facebook-github-bot
Copy link

@mrkev has updated the pull request. View: changes

@mrkev
Copy link
Contributor Author

mrkev commented Feb 12, 2018

bump!

@pelmers
Copy link
Contributor

pelmers commented Feb 12, 2018

@velocityboy is currently on PTO! I imagine he'll reply in a few days

@mrkev
Copy link
Contributor Author

mrkev commented Feb 13, 2018

Ah ok 😄 just making sure this doesn't get buried

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants